cert rotation - #202
Open
JPadovano1483 wants to merge 7 commits into
Open
cert rotation#202JPadovano1483 wants to merge 7 commits into
JPadovano1483 wants to merge 7 commits into
Conversation
fgiorgetti
reviewed
Sep 24, 2026
fgiorgetti
left a comment
fgiorgetti
left a comment
Member
There was a problem hiding this comment.
It worked well for me.
I have created a backbone network and rotated multiple certificates many times, CA, and the leaf certs as well.
The sync mechanism seems to be doing its job and the secrets are being updated properly.
One comment I have is related to old resources being left in the VMS namespace (Issuer, CertificateRequests, Certificates, Secrets) as well as TlsCertificate records on the DB. Is there any reason to keep all of the superseded ones?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added certificate rotation handling, both for automatic rotation through cert manager as well as manual rotation via the GUI. TLS secrets now get synced over state-sync to backbone sites. I increased the default certificate expirations so that CAs are not regularly rotating.
For leaf rotation, cert-manager's system of in-place rotation is followed. Cert-manager does have much support for rotating CAs (other that in-place rotation for the CA only. Leaves do not get re-signed). To address this, a new CA certificate is created when the CA is set to rotate and new leaf certificates will be issued under the new CA. The new tree is identical to the expiring tree. The expiring tree is marked as superceded, and the new tree will be served going forward.
With the possible removal of the need for vanCAs, the "vanCA rotation" commit may not be needed here.